Rework address roles, making Address::role optional, rework determining uplink/downlinks/parent/children
This commit is contained in:
@@ -4,7 +4,7 @@ namespace App\Console\Commands\Debug;
|
||||
|
||||
use Illuminate\Console\Command;
|
||||
|
||||
use App\Models\{Address,Domain};
|
||||
use App\Models\Domain;
|
||||
|
||||
class ZoneCheck extends Command
|
||||
{
|
||||
@@ -25,77 +25,23 @@ class ZoneCheck extends Command
|
||||
$this->warn('Zone: '.$zo->zone_id);
|
||||
$this->info(sprintf('- Our address(es): %s',our_address($do)->pluck('ftn4d')->join(',')));
|
||||
|
||||
$this->table(['id','ftn','role','parent','our_address','region_id','host_id','hub_id','system','notes'],$zo->addresses()->FTNorder()->active()->with(['system'])->get()->transform(function($item) {
|
||||
$this->table(['id','ftn','role','parent','children','downlinks','uplink','send from','region_id','system','notes'],$zo->addresses()->FTNorder()->active()->with(['system'])->get()->transform(function($item) {
|
||||
return [
|
||||
'id'=>$item->id,
|
||||
'ftn'=>$item->ftn4d,
|
||||
'role'=>$item->role_name,
|
||||
'parent'=>($x=$item->parent())?->ftn4d,
|
||||
'our_address'=>$x ? our_address($item->parent())->ftn4d : '',
|
||||
'parent'=>$item->parent()?->ftn4d,
|
||||
'children'=>$item->children()->count(),
|
||||
'downlinks'=>$item->downlinks()->count(),
|
||||
'uplink'=>($x=$item->uplink())?->ftn4d,
|
||||
'send from'=>$x ? our_address($item->uplink())?->ftn4d : '',
|
||||
'region_id'=>$item->region_id,
|
||||
'host_id'=>$item->host_id,
|
||||
'hub_id'=>$item->hub_id,
|
||||
'system'=>$item->system->name,
|
||||
'notes'=>$this->check($item),
|
||||
'notes'=>$item->isRoleOverride() ? 'Role Override' : '',
|
||||
];
|
||||
}));
|
||||
}
|
||||
|
||||
return Command::SUCCESS;
|
||||
}
|
||||
|
||||
/**
|
||||
* Check that an address is defined correctly
|
||||
*
|
||||
* @param Address $ao
|
||||
* @return string
|
||||
*/
|
||||
private function check(Address $ao): string
|
||||
{
|
||||
// ZC address
|
||||
if ($ao->role === Address::NODE_ZC) {
|
||||
if (($ao->region_id === 0) && ($ao->host_id === 0) && ($ao->node_id === 0) && is_null($ao->hub_id) && ($ao->point_id === 0))
|
||||
return 'OK';
|
||||
|
||||
else
|
||||
return 'INVALID ZC address';
|
||||
}
|
||||
|
||||
// RC address
|
||||
if ($ao->role === Address::NODE_RC) {
|
||||
if ($ao->region_id && ($ao->region_id === $ao->host_id) && ($ao->node_id === 0) && is_null($ao->hub_id) && ($ao->point_id === 0))
|
||||
return 'OK';
|
||||
else
|
||||
return 'INVALID RC address';
|
||||
}
|
||||
|
||||
// NC address
|
||||
if ($ao->role === Address::NODE_NC) {
|
||||
if (($ao->node_id === 0) && is_null($ao->hub_id) && ($ao->point_id === 0))
|
||||
return 'OK';
|
||||
else
|
||||
return 'INVALID NC address';
|
||||
}
|
||||
|
||||
// HUB address
|
||||
if ($ao->role === Address::NODE_HC) {
|
||||
if (($ao->node_id !== 0) && is_null($ao->hub_id) && ($ao->point_id === 0))
|
||||
return 'OK';
|
||||
else
|
||||
return 'INVALID HUB address';
|
||||
}
|
||||
|
||||
// POINT address
|
||||
if ($ao->role === Address::NODE_POINT) {
|
||||
if ($ao->point_id !== 0)
|
||||
return 'OK';
|
||||
else
|
||||
return 'INVALID POINT address';
|
||||
}
|
||||
|
||||
if ($ao->region_id && ($ao->host_id === 0))
|
||||
return 'INVALID REGION NODE';
|
||||
|
||||
return '';
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user