bbs/clrghouz
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Logging some @todos to do

Browse Source
This commit is contained in:
Deon George 2025-04-17 09:36:39 +10:00
parent 1461647159
commit 6284795e3b
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/Classes/FTN/Message.php
View File

@ -27,7 +27,7 @@ use App\Traits\ObjectIssetFix;
* = By definition we should know the author node, because it's either ours or (will be) in the nodelist (but it might not be there yet) * = By definition we should know the author node, because it's either ours or (will be) in the nodelist (but it might not be there yet)
* = The target node may not be in the nodelist (anymore) * = The target node may not be in the nodelist (anymore)
* *
* + Echomail - only has source addresses (MUST have an AREA: tag, otherwise its netmail)) * + Echomail - only has source addresses (MUST have an AREA: tag, otherwise its netmail)
* a Origin Line " * Origin: <some text> (z:f/n.p) * a Origin Line " * Origin: <some text> (z:f/n.p)
* b MSGID Kludge "MSGID: z:f/n.p<@domain> <sometext> * b MSGID Kludge "MSGID: z:f/n.p<@domain> <sometext>
* c net/node from msg headers (dst should be to hub to be processed) * c net/node from msg headers (dst should be to hub to be processed)
@ -329,6 +329,7 @@ class Message extends FTNBase
switch ($key) { switch ($key) {
// From Addresses // From Addresses
// @todo $this->src no longer appears to be defined
case 'fz': return (int)Arr::get($this->src,'z'); case 'fz': return (int)Arr::get($this->src,'z');
case 'fn': return (int)($x=$this->src) ? Arr::get($x,'n') : Arr::get($this->header,'onet'); case 'fn': return (int)($x=$this->src) ? Arr::get($x,'n') : Arr::get($this->header,'onet');
case 'ff': return (int)($x=$this->src) ? Arr::get($x,'f') : Arr::get($this->header,'onode'); case 'ff': return (int)($x=$this->src) ? Arr::get($x,'f') : Arr::get($this->header,'onode');
@ -677,6 +678,7 @@ class Message extends FTNBase
* @param Echomail|Netmail $o * @param Echomail|Netmail $o
* @return Echomail|Netmail * @return Echomail|Netmail
* @throws InvalidPacketException * @throws InvalidPacketException
* @todo Remove parsing $o as second object, make this private, and use $this->... instead of $o->...
*/ */
public function unpackMessage(string $message,Echomail|Netmail $o): Echomail|Netmail public function unpackMessage(string $message,Echomail|Netmail $o): Echomail|Netmail
{ {
@ -895,6 +897,10 @@ class Message extends FTNBase
); );
$validator->after(function($validator) { $validator->after(function($validator) {
// @todo If the message has an INTL kludge, we send the message to our ZC, and if we are the ZC onto the dst ZC
// @todo So validate we can send it on
// @todo This validation below is incorrect - netmails only need to have an INTL if they are traversing zones
// @todo Without an INTL it is affecting our determination of a source zone/dst zone
if (($this->mo instanceof Netmail) && (! $this->mo->kludges->has('INTL'))) if (($this->mo instanceof Netmail) && (! $this->mo->kludges->has('INTL')))
$validator->errors()->add('no-intl','Netmail message is missing INTL KLUDGE.'); $validator->errors()->add('no-intl','Netmail message is missing INTL KLUDGE.');

2
app/Console/Commands/PacketProcess.php
View File

@ -34,6 +34,8 @@ use App\Models\Address;
* - To areafix (processed) * - To areafix (processed)
* - To ping (respond) * - To ping (respond)
* - With trace turned on (respond) * - With trace turned on (respond)
*
* @todo Enable force processing packets when the password is wrong
*/ */
class PacketProcess extends Command class PacketProcess extends Command
{ {