From bfab8c7d26bae0b443b5cd4427f107b98b76e37e Mon Sep 17 00:00:00 2001
From: Deon George <deon@dege.au>
Date: Wed, 25 Sep 2024 00:10:50 +1000
Subject: [PATCH] If we get a file we cannot parse, then send back a SKIP and
 keep going

---
 app/Classes/Protocol/Binkp.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/app/Classes/Protocol/Binkp.php b/app/Classes/Protocol/Binkp.php
index 79df967..f3cd325 100644
--- a/app/Classes/Protocol/Binkp.php
+++ b/app/Classes/Protocol/Binkp.php
@@ -894,16 +894,13 @@ final class Binkp extends BaseProtocol
 		//if ($this->recv->fd)
 		//	$this->recv->close();
 
+		// If we cannot understand the file, we'll send back a SKIP
 		if (! ($file=$this->file_parse($buf))) {
 			Log::error(sprintf('%s:! UNPARSABLE file info [%s]',self::LOGKEY,$buf));
 			$this->msgs(self::BPM_ERR,sprintf('M_FILE: unparsable file info: "%s", what are you on?',$buf));
+			$this->msgs(self::BPM_SKIP,$buf);
 
-			if ($this->sessionGet(self::SE_SENDFILE))
-				$this->send->close(FALSE,$this->node);
-
-			$this->rc = self::S_FAILURE;
-
-			return FALSE;
+			return TRUE;
 		}
 
 		// In NR mode, when we got -1 for the file offsite, the reply to our get will confirm our requested offset.