Logging changes

ChangeLog

@@ -4679,6 +4679,7 @@ v0.33.20        10-Feb-2002
 
 	mbmon:
 		The top statusbar now displays the bbs Free/Down/Busy status.
+		Removed nonsense error message when stopped on a signal.
 
 	mbfido:
 		In AreaMgr and FileMgr changed aka matching for area 
@@ -4766,6 +4767,7 @@ v0.33.20        10-Feb-2002
 	mbmsg:
 		When creating non-existend message bases, the path is created
 		first if it doesn't exist.
+		Removed nonsense error message when stopped on a signal.
 
 	mbfile:
 		The mbfile index command now creates the html pages using the
@@ -4776,16 +4778,26 @@ v0.33.20        10-Feb-2002
 		Missing download directories are created mode 0775.
 		Moved check for empty areas to mbfile check function.
 		The mbfile move command now also moves the thumbnails.
+		Better console error reporting when files are copied.
+		Removed nonsense error message when stopped on a signal.
 
 	mball:
 		Will not crash anymore when it needs more then 10 minutes to
 		create the allfiles and newfiles lists.
+		Removed nonsense error message when stopped on a signal.
 
 	mbaff:
 		The High-ascii table to translate to lowercase has now the
 		right values to translate the ansi graphics.
 		Now uses the template newfiles and filefind to create the 
 		reports.
+		Removed nonsense error message when stopped on a signal.
+
+	mbdiff:
+		Removed nonsense error message when stopped on a signal.
+
+	mbindex:
+		Removed nonsense error message when stopped on a signal.
 
 	mbtask:
 		Removed some debug logging.
@@ -4824,6 +4836,7 @@ v0.33.20        10-Feb-2002
 		All filetransfer times and cps rates are calculated in mSecs.
 		Splitted no TCP settings in no IBN, no IFC and no ITN.
 		Removed settings for Non-hold mail and Pickup Primary.
+		Removed nonsense error message when stopped on a signal.
 
 	mbout:
 		The status display has now 9 digits for the outbound size.
@@ -4831,6 +4844,7 @@ v0.33.20        10-Feb-2002
 		nodes "try" counter, ie. make an undiable node try to call 
 		again.
 		The status command displays the call attempts.
+		Removed nonsense error message when stopped on a signal.
 
 	mbsebbs:
 		On some systems the download taglists contained garbage after
@@ -4848,9 +4862,11 @@ v0.33.20        10-Feb-2002
 		Fixed the problems with the safecracker door. Removed the
 		cheat codes and added a delay for the display of the safe
 		opening.
+		Removed nonsense error message when stopped on a signal.
 
 	mbnewusr:
 		New users have the default internal fullscreen editor.
+		Removed nonsense error message when stopped on a signal.
 
 	mbuser:
 		If a new user has registered and not yet used the bbs, mbuser

mbcico/mbcico.c

@@ -114,7 +114,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			Syslog('+', "Terminated with error %d", onsig);
 	}

mbcico/mbout.c

@@ -102,7 +102,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}

mbfido/mbaff.c

@@ -70,7 +70,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}

mbfido/mbdiff.c

@@ -94,7 +94,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}

mbfido/mbfadopt.c

@@ -52,7 +52,7 @@ void AdoptFile(int Area, char *File, char *Description)
     char		Desc[256], TDesc[256];
     int			IsArchive = FALSE, MustRearc = FALSE, UnPacked = FALSE;
     int			IsVirus = FALSE, File_Id = FALSE;
-    int			i, j, k, lines = 0, File_id_cnt = 0;
+    int			i, j, k, lines = 0, File_id_cnt = 0, rc;
     struct FILERecord	fdb;
 
     Syslog('-', "Adopt(%d, %s, %s)", Area, MBSE_SS(File), MBSE_SS(Description));
@@ -83,10 +83,10 @@ void AdoptFile(int Area, char *File, char *Description)
 	    Syslog('+', "No known archive: %s", File);
 	    sprintf(temp2, "%s/tmp/arc/%s", getenv("MBSE_ROOT"), File);
 	    mkdirs(temp2, 0755);
-	    if (file_cp(temp, temp2)) {
+	    if ((rc = file_cp(temp, temp2))) {
 		WriteError("Can't copy file to %s", temp2);
 		if (!do_quiet)
-		    printf("Can't copy file to %s\n", temp2);
+		    printf("Can't copy file to %s, %s\n", temp2, strerror(rc));
 		die(0);
 	    } else {
 		if (!do_quiet) {

mbfido/mbfimport.c

@@ -49,7 +49,7 @@ void ImportFiles(int Area)
 {
     char		*pwd, *temp, *temp2, *String, *token, *dest, *unarc;
     FILE		*fbbs;
-    int			Append = FALSE, Files = 0, i, j = 0, k = 0, x, Doit;
+    int			Append = FALSE, Files = 0, rc, i, j = 0, k = 0, x, Doit;
     int			Imported = 0, Errors = 0, Present = FALSE;
     struct FILERecord   fdb;
     struct stat		statfile;
@@ -104,8 +104,10 @@ void ImportFiles(int Area)
 			Syslog('+', "Unknown archive format %s", temp);
 			sprintf(temp2, "%s/tmp/arc/%s", getenv("MBSE_ROOT"), fdb.LName);
 			mkdirs(temp2, 0755);
-			if (file_cp(temp, temp2)) {
+			if ((rc = file_cp(temp, temp2))) {
 			    WriteError("Can't copy file to %s", temp2);
+			    if (!do_quiet)
+				printf("Can't copy file to %s, %s\n", temp2, strerror(rc));
 			    Doit = FALSE;
 			} else {
 			    if (!do_quiet) {

mbfido/mbfutil.c

@@ -87,7 +87,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}
@@ -309,11 +309,13 @@ int AddFile(struct FILERecord fdb, int Area, char *DestPath, char *FromPath)
 {
     char    *temp1, *temp2;
     FILE    *fp1, *fp2;
-    int	    i, Insert, Done = FALSE, Found = FALSE;
+    int	    i, rc, Insert, Done = FALSE, Found = FALSE;
 
     mkdirs(DestPath, 0755);
-    if (file_cp(FromPath, DestPath)) {
+    if ((rc = file_cp(FromPath, DestPath))) {
 	WriteError("Can't move file in place");
+	if (!do_quiet)
+	    printf("Can't copy file to %s, %s\n", temp2, strerror(rc));
 	return FALSE;
     }
     chmod(DestPath, 0644);

mbfido/mbindex.c

@@ -188,7 +188,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}

mbfido/mbmsg.c

@@ -223,7 +223,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}

mbmon/mbmon.c

@@ -42,7 +42,7 @@ static void die(int onsig)
 	signal(onsig, SIG_IGN);
 	screen_stop(); 
 	if (onsig && (onsig <= NSIG))
-		Syslog('?', "$Finished on signal %s", SigName[onsig]);
+		Syslog('?', "Finished on signal %s", SigName[onsig]);
 	else
 		Syslog(' ', "Normally finished");
 	ExitClient(0);

mbsebbs/mball.c

@@ -87,7 +87,7 @@ void die(int onsig)
 
 	if (onsig) {
 		if (onsig <= NSIG)
-			WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+			WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 		else
 			WriteError("Terminated with error %d", onsig);
 	}

mbsebbs/mbstat.c

@@ -85,7 +85,7 @@ void die(int onsig)
 	signal(onsig, SIG_IGN);
 
 	if (onsig)
-		WriteError("$Terminated on signal %d", onsig);
+		WriteError("Terminated on signal %d", onsig);
 
 	if (!do_quiet) {
 		colour(7, 0);

mbsebbs/timeout.c

@@ -82,7 +82,7 @@ void die(int onsig)
 			Syslog('+', "User inactivity timeout");
 		} else {
 			if (onsig <= NSIG)
-				WriteError("$Terminated on signal %d (%s)", onsig, SigName[onsig]);
+				WriteError("Terminated on signal %d (%s)", onsig, SigName[onsig]);
 			else
 				WriteError("Terminated with error %d", onsig);
 		}