Improved exception handling and other minor fixes

2013-05-10 00:42:54 +10:00
parent d1c0d48250
commit 077c1923f3
11 changed files with 45 additions and 75 deletions
--- a/modules/invoice/classes/Controller/Reseller/Invoice.php
+++ b/modules/invoice/classes/Controller/Reseller/Invoice.php
@@ -15,10 +15,8 @@ class Controller_Reseller_Invoice extends Controller_Invoice {

 		$ao = ORM::factory('Account',$id);

-		if (! $ao->loaded() OR ! Auth::instance()->authorised($ao)) {
-			$this->template->content = 'Unauthorised or doesnt exist?';
-			return FALSE;
-		}
+		if (! $ao->loaded() OR ! Auth::instance()->authorised($ao))
+			throw HTTP_Exception::factory(403,'Unauthorised or doesnt exist?');

 		Block::add(array(
 			'body'=>$output,