deon/osb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improvements for service_change and service_cancel
All checks were successful
Create Docker Image / Build Docker Image (x86_64) (push) Successful in 37s
Details
Create Docker Image / Final Docker Image Manifest (push) Successful in 10s
Details

Browse Source
This commit is contained in:
Deon George
2024-08-16 08:20:58 +10:00
parent 5f66987a3e
commit 3b40e92c48
12 changed files with 186 additions and 327 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Mail/CancelRequest.php
View File

@@ -15,15 +15,15 @@ class CancelRequest extends Mailable
use Queueable, SerializesModels;
public Service $service;
public string $notes;
public ?string $notes;
/**
* Create a new message instance.
*
* @param Service $o
* @param string $notes
* @param string|NULL $notes
*/
public function __construct(Service $o,string $notes='')
public function __construct(Service $o,string $notes=NULL)
{
$this->service = $o;
$this->notes = $notes;
@@ -40,7 +40,9 @@ class CancelRequest extends Mailable
switch (get_class($this->service->type)) {
case Service\Broadband::class:
$subject = sprintf('Cancel BROADBAND: %s',$this->service->type->service_address);
$subject = sprintf('Cancel BROADBAND: %s (%s)',
$this->service->type->service_number,
$this->service->type->service_address);
break;
case Service\Phone::class:

12
app/Mail/ChangeRequest.php
View File

@@ -15,18 +15,18 @@ class ChangeRequest extends Mailable
use Queueable, SerializesModels;
public Service $service;
public string $notes;
public ?string $notes;
/**
* Create a new message instance.
*
* @param Service $o
* @param string $notes
* @param string|NULL $notes
*/
public function __construct(Service $o,string $notes='')
public function __construct(Service $o,string $notes=NULL)
{
$this->service = $o;
$this->notes = $notes ?? '';
$this->notes = $notes;
}
/**
@@ -40,7 +40,9 @@ class ChangeRequest extends Mailable
switch (get_class($this->service->type)) {
case Service\Broadband::class:
$subject = sprintf('Change BROADBAND: %s',$this->service->type->service_address);
$subject = sprintf('Change BROADBAND: %s (%s)',
$this->service->type->service_number,
$this->service->type->service_address);
break;
case Service\Phone::class: