More Product Model optimisation

app/Interfaces/ProductItem.php

@@ -20,30 +20,6 @@ interface ProductItem
 	 */
 	public function allowance_string(): string;
 
-	/**
-	 * Return the contract term for this product when sold as a service
-	 *
-	 * @return int Months
-	 */
-	public function getContractTermAttribute(): int;
-
-	/**
-	 * Return the product cost
-	 *
-	 * @return float
-	 */
-	public function getCostAttribute(): float;
-
-	/**
-	 * Return the supplier class
-	 * If there is a model relationship return:
-	 *   return $this->getRelationValue('supplier');
-	 * otherwise return a stdClass with name
-	 *
-	 * @return mixed
-	 */
-	public function getSupplierAttribute();
-
 	/**
 	 * Does this offering capture usage information
 	 *

app/Interfaces/SupplierItem.php

@@ -1,81 +0,0 @@
-<?php
-
-namespace App\Interfaces;
-
-interface SupplierItem
-{
-	/* RELATIONS */
-
-	/**
-	 * Supplier that provides this offering
-	 *
-	 * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
-	 */
-	public function supplier_detail();
-
-	/**
-	 * Available products created from this supplier offering
-	 *
-	 * @return \Illuminate\Database\Eloquent\Relations\HasMany
-	 */
-	public function products();
-
-	/* ATTRIBUTES */
-
-	/**
-	 * Return the billing interval base cost including tax
-	 *
-	 * @return float
-	 */
-	public function getBaseCostTaxableAttribute(): float;
-
-	/**
-	 * Return the billing interval that the supplier charges
-	 *
-	 * @return string
-	 * @deprecated use Product::normalizeBillingInterval()
-	 */
-	public function getBillingIntervalAttribute(): int;
-
-	/**
-	 * The term that the supplier imposes on this service being connected
-	 *
-	 * @return int
-	 */
-	public function getContractTermAttribute(): int;
-
-	/**
-	 * The minimum cost of ordering this offering
-	 *
-	 * @return float
-	 */
-	public function getMinCostAttribute(): float;
-
-	/**
-	 * The minimum cost of ordering this offering including taxes
-	 *
-	 * @return float
-	 */
-	public function getMinCostTaxableAttribute(): float;
-
-	/**
-	 * Suppliers offering name (short)
-	 *
-	 * @return string
-	 */
-	public function getNameAttribute(): string;
-
-	/**
-	 * Suppliers offering name (long)
-	 *
-	 * @return string
-	 */
-	public function getNameLongAttribute(): string;
-
-	/**
-	 * Return the setup cost including tax
-	 *
-	 * @return float
-	 */
-	public function getSetupCostTaxableAttribute(): float;
-}