Move charge actions to ChargeController, implemented charge delete

app/Http/Controllers/ChargeController.php

@@ -0,0 +1,69 @@
+<?php
+
+namespace App\Http\Controllers;
+
+use App\Http\Requests\ChargeAdd;
+use App\Models\Charge;
+use Illuminate\Http\RedirectResponse;
+use Illuminate\Http\Request;
+use Illuminate\Support\Arr;
+use Illuminate\Support\Facades\Gate;
+use Illuminate\View\View;
+
+class ChargeController extends Controller
+{
+	/**
+	 * Add a charge to a service/account
+	 *
+	 * @param ChargeAdd $request
+	 * @return RedirectResponse
+	 */
+	public function addedit(ChargeAdd $request): RedirectResponse
+	{
+		$o = Charge::findOrNew(Arr::get($request->validated(),'id'));
+
+		// Dont update processed charges
+		if ($o->processed)
+			abort(403);
+
+		$o->forceFill(array_merge(Arr::except($request->validated(),['id']),['active'=>TRUE]));
+		$o->save();
+
+		return redirect()
+			->back()
+			->with('success',sprintf('Charge %s #%d',$o->wasRecentlyCreated ? 'Created' : 'Updated',$o->id));
+	}
+
+	public function delete(Charge $o): array
+	{
+		if (Gate::allows('delete',$o)) {
+			$o->delete();
+
+			return ['ok'];
+
+		} else {
+			abort(401,'Not Allowed');
+		}
+	}
+
+	/**
+	 * Add a charge to a service/account
+	 *
+	 * @param Request $request
+	 * @return View
+	 */
+	public function edit(Request $request): View
+	{
+		$o = Charge::where('processed',FALSE)
+			->where('id',$request->id)
+			->firstOrFail();
+
+		if (Gate::allows('update',$o)) {
+			return view('theme.backend.adminlte.charge.widget.addedit')
+				->with('o',$o)
+				->with('so',$o->service);
+		}
+
+		abort(403);
+	}
+}

app/Http/Controllers/ServiceController.php

@@ -266,49 +266,6 @@ class ServiceController extends Controller
 		}
 	}
 
-	/**
-	 * Add a charge to a service/account
-	 *
-	 * @param ChargeAdd $request
-	 * @return RedirectResponse
-	 */
-	public function charge_addedit(ChargeAdd $request): RedirectResponse
-	{
-		$o = Charge::findOrNew(Arr::get($request->validated(),'id'));
-
-		// Dont update processed charges
-		if ($o->processed)
-			abort(403);
-
-		$o->forceFill(array_merge(Arr::except($request->validated(),['id']),['active'=>TRUE]));
-		$o->save();
-
-		return redirect()
-			->back()
-			->with('success',sprintf('Charge %s #%d',$o->wasRecentlyCreated ? 'Created' : 'Updated',$o->id));
-	}
-
-	/**
-	 * Add a charge to a service/account
-	 *
-	 * @param Request $request
-	 * @return View
-	 */
-	public function charge_edit(Request $request): View
-	{
-		$o = Charge::where('processed',FALSE)
-			->where('id',$request->id)
-			->firstOrFail();
-
-		if (Gate::allows('update',$o)) {
-			return view('theme.backend.adminlte.charge.widget.addedit')
-				->with('o',$o)
-				->with('so',$o->service);
-		}
-
-		abort(403);
-	}
-
 	/**
 	 * List all the domains managed by the user
 	 *

app/Models/Charge.php

@@ -70,7 +70,7 @@ class Charge extends Model
 
 	/* ATTRIBUTES */
 
-	public function getNameAttribute()
+	public function getNameAttribute(): string
 	{
 		return sprintf('%s %s',
 			$this->description,
@@ -93,4 +93,14 @@ class Charge extends Model
 	{
 		return Arr::get(InvoiceItem::type,$this->type);
 	}
+
+	/**
+	 * Is this charge processable
+	 *
+	 * @return bool
+	 */
+	public function getUnprocessedAttribute(): bool
+	{
+		return $this->active && (! $this->processed);
+	}
 }

app/Models/Service.php

@@ -1275,7 +1275,7 @@ class Service extends Model implements IDs
 		if ((($future == TRUE) OR (($future == FALSE) AND ($this->invoice_to >= $billdate)))
 			AND ! $this->invoice_items->filter(function($item) { return $item->module_id == 30 AND ! $item->exists; })->count())
 		{
-			foreach ($this->charges->filter(function($item) { return ! $item->processed; }) as $oo) {
+			foreach ($this->charges->filter(function($item) { return $item->unprocessed; }) as $oo) {
 				$o = new InvoiceItem;
 				$o->active = TRUE;
 				$o->service_id = $oo->service_id;