deon/osb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PHP deprecation fixes, assigning null arguments in methods
All checks were successful
Create Docker Image / Build Docker Image (x86_64) (push) Successful in 41s
Details
Create Docker Image / Final Docker Image Manifest (push) Successful in 9s
Details

Browse Source
This commit is contained in:
Deon George
2025-05-22 18:37:04 +10:00
parent 251aefa947
commit b37045acca
11 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Models/Product.php
View File

@@ -206,7 +206,7 @@ class Product extends Model
* @param Group|NULL $go
* @return float
*/
private function _charge(string $type,int $timeperiod=NULL,Group $go=NULL): float
private function _charge(string $type,?int $timeperiod=NULL,?Group $go=NULL): float
{
// We'll cache this for performance
static $default = NULL;
@@ -296,7 +296,7 @@ class Product extends Model
* @param Group|null $go
* @return float
*/
public function min_charge(int $timeperiod=NULL,Group $go=NULL): float
public function min_charge(?int $timeperiod=NULL,?Group $go=NULL): float
{
return $this->setup_charge($timeperiod,$go)
+ $this->base_charge($timeperiod,$go)*Invoice::billing_change($this->billing_interval,$this->type->billing_interval)*$this->contract_term;