From 64cc21d8198c5ba91995f04ae7231b6b1848b224 Mon Sep 17 00:00:00 2001 From: Deon George Date: Tue, 29 Apr 2025 14:15:02 +0930 Subject: [PATCH] Fix logic processing isDirty() for MD5Update apps by checking that the new & old values dont equal before checking their md5 value --- app/Traits/MD5Updates.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Traits/MD5Updates.php b/app/Traits/MD5Updates.php index 0c8cde18..3fe97927 100644 --- a/app/Traits/MD5Updates.php +++ b/app/Traits/MD5Updates.php @@ -12,7 +12,8 @@ trait MD5Updates public function isDirty(): bool { foreach ($this->values_old->dot()->keys()->merge($this->values->dot()->keys())->unique() as $dotkey) - if (md5(Arr::get($this->values_old->dot(),$dotkey)) !== Arr::get($this->values->dot(),$dotkey)) + if ((Arr::get($this->values_old->dot(),$dotkey) !== Arr::get($this->values->dot(),$dotkey)) + && (md5(Arr::get($this->values_old->dot(),$dotkey)) !== Arr::get($this->values->dot(),$dotkey))) return TRUE; return FALSE;