From 6954b0908932bdec09971706aeebc12f58ad4ff1 Mon Sep 17 00:00:00 2001
From: Deon George <deon@dege.au>
Date: Sun, 27 Apr 2025 14:12:01 +1000
Subject: [PATCH] @todo udpates

---
 app/Classes/LDAP/Schema/ObjectClass.php | 2 +-
 app/Classes/LDAP/Server.php             | 1 +
 app/Ldap/Entry.php                      | 2 --
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/app/Classes/LDAP/Schema/ObjectClass.php b/app/Classes/LDAP/Schema/ObjectClass.php
index 50afa518..8cfb4cae 100644
--- a/app/Classes/LDAP/Schema/ObjectClass.php
+++ b/app/Classes/LDAP/Schema/ObjectClass.php
@@ -43,7 +43,7 @@ final class ObjectClass extends Base
 	 *
 	 * @param string $line Schema Line
 	 * @param Server $server
-	 * @todo Change $server to $connection, no need to store the server object here
+	 * @todo Deprecate this $server variable? It is only used for isForceMay() determination, and that might be better done elsewhere?
 	 */
 	public function __construct(string $line,Server $server)
 	{
diff --git a/app/Classes/LDAP/Server.php b/app/Classes/LDAP/Server.php
index 7e61f095..fe669339 100644
--- a/app/Classes/LDAP/Server.php
+++ b/app/Classes/LDAP/Server.php
@@ -310,6 +310,7 @@ final class Server
 	 * as configured in config.php.
 	 *
 	 * @return boolean True if the specified attribute is configured to be force as a may attribute
+	 * @todo There are 3 isForceMay() functions - we only need one
 	 */
 	public function isForceMay($attr_name): bool
 	{
diff --git a/app/Ldap/Entry.php b/app/Ldap/Entry.php
index 2dc9c91c..eb2a97ba 100644
--- a/app/Ldap/Entry.php
+++ b/app/Ldap/Entry.php
@@ -69,8 +69,6 @@ class Entry extends Model
 
 	/**
 	 * Determine if the new and old values for a given key are equivalent.
-	 *
-	 * @todo This function barfs on language tags, eg: key = givenname;lang-ja
 	 */
 	protected function originalIsEquivalent(string $key): bool
 	{