Minor code consistency changes, no functional changes

README.md

@@ -48,7 +48,7 @@ Entry Editing:
   - [ ] JpegPhoto Create/Delete
   - [ ] Binary attribute upload
   - [ ] If removing an objectClass, remove all attributes that only that objectclass provided
-  - [ ] Rename an entry
+  - [ ] Move an entry
   - [ ] Group membership selection
   - [ ] Attribute tag creation
 

app/Http/Controllers/HomeController.php

@@ -29,7 +29,7 @@ class HomeController extends Controller
 {
 	private const LOGKEY = 'CHc';
 
-	private const INTERNAL_POST = ['_auto_value','_key','_rdn','_rdn_value','_step','_template','_token','_userpassword_hash'];
+	private const INTERNAL_POST = ['_auto_value','_key','_rdn','_rdn_new','_rdn_value','_step','_template','_token','_userpassword_hash'];
 
 	/**
 	 * Create a new object in the LDAP server
@@ -206,7 +206,7 @@ class HomeController extends Controller
 		}
 
 		return Redirect::to('/')
-			->with('success',[sprintf('%s: %s',__('Deleted'),$dn)]);
+			->with('success',sprintf('%s: %s',__('Deleted'),$dn));
 	}
 
 	public function entry_export(Request $request,string $id): \Illuminate\View\View
@@ -298,7 +298,7 @@ class HomeController extends Controller
 				$request->get('_userpassword_hash'));
 
 		if (! $o->getDirty())
-			return back()
+			return Redirect::back()
 				->withInput()
 				->with('note',__('No attributes changed'));
 
@@ -307,6 +307,31 @@ class HomeController extends Controller
 			->with('o',$o);
 	}
 
+	public function entry_rename(Request $request): \Illuminate\Http\RedirectResponse|\Illuminate\View\View
+	{
+		$from_dn = Crypt::decryptString($request->post('dn'));
+		Log::info(sprintf('%s:Renaming [%s] to [%s]',self::LOGKEY,$from_dn,$request->post('_rdn_new')));
+
+		$o = config('server')->fetch($from_dn);
+
+		if (! $o)
+			return Redirect::back()
+				->withInput()
+				->with('note',__('DN doesnt exist'));
+
+		try {
+			$o->rename($request->post('_rdn_new'));
+
+		} catch (\Exception $e) {
+			return Redirect::to('/')
+				->with('failed',$e->getMessage());
+		}
+
+		return Redirect::to('/')
+			->withInput(['_key'=>Crypt::encryptString('*dn|'.$o->getDN())])
+			->with('success',sprintf('%s: %s',__('Entry renamed'),$from_dn));
+	}
+
 	/**
 	 * Update a DN entry
 	 *
@@ -326,7 +351,7 @@ class HomeController extends Controller
 			$o->{$key} = array_filter($value);
 
 		if (! $dirty=$o->getDirty())
-			return back()
+			return Redirect::back()
 				->withInput()
 				->with('note',__('No attributes changed'));
 
@@ -505,8 +530,8 @@ class HomeController extends Controller
 		// Setup
 		$cmd = NULL;
 		$dn = NULL;
-		$key = $request->get('_key',old('_key'))
-			? Crypt::decryptString($request->get('_key',old('_key')))
+		$key = ($x=$request->get('_key',old('_key')))
+			? Crypt::decryptString($x)
 			: NULL;
 
 		// Determine if our key has a command
@@ -518,9 +543,9 @@ class HomeController extends Controller
 				$dn = ($m[2] !== '_NOP') ? $m[2] : NULL;
 			}
 
-		} elseif (old('dn',$request->get('_key'))) {
+		} elseif ($x=old('dn',$request->get('_key'))) {
 			$cmd = 'dn';
-			$dn = Crypt::decryptString(old('dn',$request->get('_key')));
+			$dn = Crypt::decryptString($x);
 		}
 
 		return ['cmd'=>$cmd,'dn'=>$dn];

resources/views/components/attribute/widget/options.blade.php

@@ -6,7 +6,7 @@
 @php($clone=FALSE)
 <span class="p-0 m-0">
 	@if($o->is_rdn)
-		<button class="btn btn-sm btn-outline-focus mt-3" disabled><i class="fas fa-fw fa-exchange"></i> @lang('Rename')</button>
+		<span id="entry-rename" class="btn btn-sm btn-outline-focus mt-3" data-bs-toggle="modal" data-bs-target="#page-modal"><i class="fas fa-fw fa-exchange"></i> @lang('Rename')</span>
 	@elseif($edit && $o->can_addvalues)
 		@switch(get_class($o))
 			@case(Certificate::class)
@@ -26,7 +26,7 @@
 				@break
 
 			@case(ObjectClass::class)
-				<span type="button" @class(['btn','btn-sm','btn-outline-primary','mt-3','addable','d-none'=>(! $new)]) data-bs-toggle="modal" data-bs-target="#new_objectclass-modal"><i class="fas fa-fw fa-plus"></i> @lang('Add Objectclass')</span>
+				<span @class(['btn','btn-sm','btn-outline-primary','mt-3','addable','d-none'=>(! $new)]) data-bs-toggle="modal" data-bs-target="#new_objectclass-modal"><i class="fas fa-fw fa-plus"></i> @lang('Add Objectclass')</span>
 
 				<!-- NEW OBJECT CLASS -->
 				<div class="modal fade" id="new_objectclass-modal" tabindex="-1" aria-labelledby="new_objectclass-label" aria-hidden="true" data-bs-backdrop="static">

resources/views/components/success.blade.php

@@ -1,11 +1,5 @@
 @if(session()->has('success'))
-	<div class="alert alert-success">
-		<h4 class="alert-heading"><i class="fas fa-fw fa-thumbs-up"></i> Success!</h4>
-		<hr>
-		<ul class="square">
-			@foreach(session()->get('success') as $item)
-				<li>{{ $item }}</li>
-			@endforeach
-		</ul>
+	<div class="alert alert-success p-2">
+		<p class="m-0"><i class="fas fa-fw fa-thumbs-up"></i> {{ session()->pull('success') }}</p>
 	</div>
 @endif

resources/views/frames/dn.blade.php

@@ -52,9 +52,10 @@
 		</div>
 	@endif
 
+	<x-success/>
+	<x-updated/>
 	<x-note/>
 	<x-error/>
-	<x-updated/>
 	<x-failed/>
 @endsection
 
@@ -282,6 +283,25 @@
 						})
 						break;
 
+					case 'entry-rename':
+						$.ajax({
+							method: 'GET',
+							url: '{{ url('modal/rename') }}/'+dn,
+							dataType: 'html',
+							cache: false,
+							beforeSend: function() {
+								that.empty().append('<span class="p-3"><i class="fas fa-3x fa-spinner fa-pulse"></i></span>');
+							},
+							success: function(data) {
+								that.empty().html(data);
+							},
+							error: function(e) {
+								if (e.status !== 412)
+									alert('That didnt work? Please try again....');
+							},
+						});
+						break;
+
 					default:
 						switch ($(item.relatedTarget).attr('name')) {
 							case 'entry-userpassword-check':

resources/views/home.blade.php

@@ -2,6 +2,7 @@
 
 @section('main-content')
 	<x-success/>
+	<x-failed/>
 
 	<div class="card card-solid mb-3">
 		<div class="card-body">

resources/views/modals/entry-rename.blade.php

@@ -0,0 +1,40 @@
+<div class="modal-header bg-dark text-white">
+	<h1 class="modal-title fs-5">
+		<strong>@lang('Rename') <strong>{{ $x=Crypt::decryptString($dn) }}</strong>
+	</h1>
+</div>
+
+<form id="entry-rename-form" method="POST" action="{{ url('entry/rename') }}">
+	<div class="modal-body">
+		@csrf
+		<input type="hidden" name="dn" value="{{ $dn }}">
+
+		<div class="row">
+			<div class="col-12">
+				<label for="rdn" class="form-label">@lang('New RDN')</label>
+				<div class="input-group mb-3">
+					<input type="text" id="rdn" name="_rdn_new" class="form-control w-25" placeholder="{{ $rdn=collect(explode(',',$x))->first() }}" value="{{ $rdn }}">
+					<span class="input-group-text" id="label">{{ collect(explode(',',$x))->skip(1)->join(',') }}</span>
+				</div>
+			</div>
+		</div>
+	</div>
+
+	<div class="modal-footer">
+		<x-modal.close/>
+		<button id="entry-rename" type="submit" class="btn btn-sm btn-primary" disabled>@lang('Rename')</button>
+	</div>
+</form>
+
+<script type="text/javascript">
+	$(document).ready(function() {
+		var rdn = '{{ $rdn }}';
+
+		// Complete the RDN
+		$('#rdn').on('input',function(item) {
+			rdn = $(this).val();
+
+			$('button[id=entry-rename]').attr('disabled',! rdn.includes('='));
+		})
+	});
+</script>

routes/web.php

@@ -49,6 +49,7 @@ Route::controller(HomeController::class)->group(function() {
 		Route::post('entry/password/check/','entry_password_check');
 		Route::post('entry/attr/add/{id}','entry_attr_add');
 		Route::post('entry/objectclass/add','entry_objectclass_add');
+		Route::post('entry/rename','entry_rename');
 		Route::post('entry/update/commit','entry_update');
 		Route::post('entry/update/pending','entry_pending_update');
 
@@ -56,6 +57,7 @@ Route::controller(HomeController::class)->group(function() {
 
 		Route::view('modal/delete/{dn}','modals.entry-delete');
 		Route::view('modal/export/{dn}','modals.entry-export');
+		Route::view('modal/rename/{dn}','modals.entry-rename');
 		Route::view('modal/userpassword-check/{dn}','modals.entry-userpassword-check');
 	});
 });