deon/phpldapadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@todo udpates

Browse Source
This commit is contained in:
Deon George 2025-04-27 14:12:01 +10:00
parent a336e58b7a
commit 6954b09089
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Classes/LDAP/Schema/ObjectClass.php
View File

@ -43,7 +43,7 @@ final class ObjectClass extends Base
* *
* @param string $line Schema Line * @param string $line Schema Line
* @param Server $server * @param Server $server
* @todo Change $server to $connection, no need to store the server object here * @todo Deprecate this $server variable? It is only used for isForceMay() determination, and that might be better done elsewhere?
*/ */
public function __construct(string $line,Server $server) public function __construct(string $line,Server $server)
{ {

1
app/Classes/LDAP/Server.php
View File

@ -310,6 +310,7 @@ final class Server
* as configured in config.php. * as configured in config.php.
* *
* @return boolean True if the specified attribute is configured to be force as a may attribute * @return boolean True if the specified attribute is configured to be force as a may attribute
* @todo There are 3 isForceMay() functions - we only need one
*/ */
public function isForceMay($attr_name): bool public function isForceMay($attr_name): bool
{ {

2
app/Ldap/Entry.php
View File

@ -69,8 +69,6 @@ class Entry extends Model
/** /**
* Determine if the new and old values for a given key are equivalent. * Determine if the new and old values for a given key are equivalent.
*
* @todo This function barfs on language tags, eg: key = givenname;lang-ja
*/ */
protected function originalIsEquivalent(string $key): bool protected function originalIsEquivalent(string $key): bool
{ {